Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set dev guide approvals to 0 #1602

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Set dev guide approvals to 0 #1602

merged 1 commit into from
Nov 4, 2024

Conversation

Noratrieb
Copy link
Member

When a subject matter expert writes some docs, there's no point in blocking them. They should just merge their stuff, we can always fix it later. If someone does want a review for their PR, they can always get it still.

discussed this with @BoxyUwU and @jieyouxu, @rust-lang/wg-rustc-dev-guide

When a subject matter expert writes some docs, there's no point in blocking them. They should just merge their stuff, we can always fix it later.
If someone does want a review for their PR, they can always get it still.
@rylev rylev merged commit d780219 into rust-lang:master Nov 4, 2024
1 check passed
@Noratrieb Noratrieb deleted the patch-1 branch November 4, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants